fix ci test error introduced by (#9781) #9838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BBuf
approved these changes
Feb 7, 2023
daquexian
reviewed
Feb 8, 2023
| math.fabs(target[epoch] - param_group["lr"]) < 1e-5, | ||
| flow.allclose( | ||
| flow.tensor(target[epoch]), | ||
| flow.tensor(param_group["lr"]), |
There was a problem hiding this comment.
这里用 np.allclose 吧，不用创建新的 tensor，同理还有 145 行
| @@ -202,7 +201,9 @@ def _test_averaged_model(self, net_device, swa_device): | |||
| averaged_dnn.update_parameters(dnn) | |||
|
|
|||
| for p_avg, p_swa in zip(averaged_params, averaged_dnn.parameters()): | |||
| self.assertTrue(flow.max(flow.abs(p_avg.cpu() - p_swa.cpu())).item() < 1e-5) | |||
| self.assertTrue( | |||
| flow.allclose(p_avg.cpu(), p_swa.cpu(), atol=1e-5, rtol=1e-4) | |||
There was a problem hiding this comment.
这里是是需要的，在test_averaged_model_all_devices中进行了不同设备之间的测试
daquexian
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flow.allclose函数test_multiplicative_lr（原来写了2个一样的）